nytimes.com

This is where you should report issues arising from the subscription filters.
Locked
scottastrophic
New Member
New Member
Posts: 9
Joined: Wed Mar 21, 2018 9:25 pm

nytimes.com

Post by scottastrophic »

Hi, I'm a developer at NYT and the following rule in the EasyPrivacy list is proving to be a nuisance:

Code: Select all

||stg.nytimes.com^
This ends up blocking all the static assets I'm trying to test out in our staging environment, not just ads. Particularly since the domain is inaccessible outside of our firewall, I don't think it really serves any public purpose... can it be removed?

Thanks!
~~Scott
scottastrophic
New Member
New Member
Posts: 9
Joined: Wed Mar 21, 2018 9:25 pm

Post by scottastrophic »

Hi @fanboy is there more information you would need in order to delete this rule?
User avatar
fanboy
EasyList Author
EasyList Author
Posts: 12223
Joined: Wed Sep 05, 2007 8:17 pm

Post by fanboy »

sample url to test it? (I couldn't see any hits myself)
intense
Contributor
Contributor
Posts: 10497
Joined: Wed Mar 27, 2013 9:56 am

Post by intense »

Particularly since the domain is inaccessible outside of our firewall
probably it's impossible to provide you such example
User avatar
fanboy
EasyList Author
EasyList Author
Posts: 12223
Joined: Wed Sep 05, 2007 8:17 pm

Post by fanboy »

Guessing we added it for a reason, so must've seen in the outside world.
scottastrophic
New Member
New Member
Posts: 9
Joined: Wed Mar 21, 2018 9:25 pm

Post by scottastrophic »

As @intense noted, it is our internal staging environment, so there's not really a URL I can give you that will resolve.
https://www.stg.nytimes.com/ is the test homepage, but you'll probably just see a 403 from the firewall.
intense
Contributor
Contributor
Posts: 10497
Joined: Wed Mar 27, 2013 9:56 am

Post by intense »

fixed for ublock origin (waiting easyprivacy for a fix)
https://github.com/uBlockOrigin/uAssets ... 0f9c7949d6
User avatar
fanboy
EasyList Author
EasyList Author
Posts: 12223
Joined: Wed Sep 05, 2007 8:17 pm

Post by fanboy »

seems premature to fix this.
Khrin
EasyList Author
EasyList Author
Posts: 3562
Joined: Fri Mar 26, 2010 8:50 pm

Post by Khrin »

fanboy wrote: Sat Apr 14, 2018 10:18 am seems premature to fix this.
I agree, until now I haven't seen a single reason of why this filter should be removed.
User avatar
fanboy
EasyList Author
EasyList Author
Posts: 12223
Joined: Wed Sep 05, 2007 8:17 pm

Post by fanboy »

We added it, so it must've been allowed to the outside world. A workable example site would be helpful to understand more.
scottastrophic
New Member
New Member
Posts: 9
Joined: Wed Mar 21, 2018 9:25 pm

Post by scottastrophic »

[mention]fanboy[/mention] I would be happy to provide an example, but I'm not sure what else I can do. I have no information as to why it was added in the first place, but I've been working at the Times for almost 9 years and it's always been our internal staging environment.
User avatar
fanboy
EasyList Author
EasyList Author
Posts: 12223
Joined: Wed Sep 05, 2007 8:17 pm

Post by fanboy »

Send me a test temp login, i'll take a look.
scottastrophic
New Member
New Member
Posts: 9
Joined: Wed Mar 21, 2018 9:25 pm

Post by scottastrophic »

It's not a login-based firewall, you need a VPN keyfob. What are you trying to verify here, that I am who I say I am? I can send you an email from my work account, if that helps.
User avatar
LanikSJ
Site Owner
Site Owner
Posts: 1806
Joined: Thu Feb 15, 2007 7:44 am
Location: /dev/null

Post by LanikSJ »

Without divulging any of your information I can vouch for you and who you work for. I think [mention]fanboy[/mention] is asking for a test login so he can reproduce the issue you're describing.
"If it ain't broke don't fix it."
scottastrophic
New Member
New Member
Posts: 9
Joined: Wed Mar 21, 2018 9:25 pm

Post by scottastrophic »

Thanks [mention]Lanik[/mention], I just don't have any way of giving him access to our internal site, so I'm not sure how to proceed. This is what it looks like from inside the firewall: http://i.imgur.com/eOfbCRA.png
User avatar
fanboy
EasyList Author
EasyList Author
Posts: 12223
Joined: Wed Sep 05, 2007 8:17 pm

Post by fanboy »

Thats the way uBo operates (from the image), if you test in Adblock Plus, does it do the same thing?
scottastrophic
New Member
New Member
Posts: 9
Joined: Wed Mar 21, 2018 9:25 pm

Post by scottastrophic »

With ABP (with Block additional tracking enabled, which pulls in the EasyPrivacy list), the page loads, but all the static files on the domain (JS and CSS) are blocked. It all comes down to line 11879 of https://easylist-downloads.adblockplus. ... rivacy.txt.
gotitbro
Postaholic
Postaholic
Posts: 866
Joined: Sat Jul 09, 2016 8:33 pm

Post by gotitbro »

I was able to find the commit where this filter was added back in 2014 by [mention]Khrin[/mention]
https://github.com/easylist/easylist/co ... 578fcdd5ac

Looks like the domain was indeed seen on the main website.
scottastrophic
New Member
New Member
Posts: 9
Joined: Wed Mar 21, 2018 9:25 pm

Post by scottastrophic »

Well, that sounds like a big screw-up on somebody's part on our side... My guess would be that someone hardcoded the staging hostname by accident. In any event, our story pages have been replatformed onto an entirely new stack from the ground up, and filtering the requests on that page now for "stg" reveals no results, so I would submit that whatever fluke caused it to surface on a production page has passed.
scottastrophic
New Member
New Member
Posts: 9
Joined: Wed Mar 21, 2018 9:25 pm

Post by scottastrophic »

Just to follow up... The stg domain is no longer requested from the article that [mention]Khrin[/mention] referenced, nor so far as I can tell any other production page on our www domain. I'm not sure exactly what guidelines led to it being added (e.g., the precise relationship between the content and the summary of the commit), but I submit that it has been at the least made obsolete by changes on our site.
Khrin
EasyList Author
EasyList Author
Posts: 3562
Joined: Fri Mar 26, 2010 8:50 pm

Post by Khrin »

Locked