Contribution to EasyList via Github

General information, announcements and questions about the EasyList subscriptions.

Moderator: EasyList Authors

Post Reply
MrNoName
New Member
New Member
Posts: 1
Joined: Sun Feb 04, 2018 7:07 pm
Reputation: 0

Contribution to EasyList via Github

Post by MrNoName » Sun Feb 04, 2018 7:24 pm

I found a page that gets broken by a EasyPrivacy filter and wanted to fix it, commit it and send a pull request back to the main project.
After I've taken a look at the previous commits, it looks like they all have a very consistent commit messages etc.
Now I'm curious, how can I contribute to EasyList? What do these commit prefixes "M:/P:/A:" even mean?
I already created an issue on Github that fits to my fixes. Can I just commit it as "?: #issuenumber"?

Sorry, if you've already answered my questions elsewhere but I couldn't find any answers.

User avatar
smed79
Liste AR Author
Liste AR Author
Posts: 14250
Joined: Sun Jan 17, 2010 4:00 am
Reputation: 156
Location: EasyList Forum

Post by smed79 » Sun Feb 04, 2018 9:31 pm

Hi,
when a commit message is sent, you must follow a particular syntax, the commit initial, followed by a parenthetical comment detailing the reasons for the change (not required but recommended), then the URL of the page that requires the addition of a filter.

Here are the 3 possible initials of commit

A: (as Addition) : means that a filter to block an advertisement has been added
P: (as Problem) : means that a problem has been fixed, for example by adding an exception in the case of a video that does not start, or in the case of an anti-adblock.
M: (as Moved or Modified) : means that a filter has been moved, added or deleted without being linked to a particular URL. This initial does not need to be followed by a URL.

e.g of pull requests https://github.com/easylist/easylist/pu ... d79+is%3A*

see also :
https://easylist.to/pages/development.html
https://easylist.to/pages/policy.html
viewtopic.php?f=23&t=22398
viewtopic.php?f=23&t=21965
viewtopic.php?f=23&t=30389
viewtopic.php?f=23&t=36976
viewtopic.php?f=88&t=36762
•► Before posting, to find your answer fast, read Forum « RULES » and use « Search »
••► Don't post clickable links » use inline text bbcode notation « [ C ] » or « [ code ] »
•••► Use vgy.me, imgur.com or imgbb.com to upload your screenshots

Post Reply