neopets.com

[Theo]

There have been some layout changes on Neopets, which seem to have caused the

Code: Select all

neopets.com###ban

filter in EasyList to start messing up the layout (the top part of the page with user information (and the login link) is cut off).

All of the top banner ads seem to have moved to the <div> with id 'pushdown_banner', so the filter should probably be changed to

Code: Select all

neopets.com###pushdown_banner

Thanks in advance.

[Erunno]

https://hg.adblockplus.org/easylist/rev/f94038410651

It will be fixed with the next automatic update of EasyList. Thanks for reporting.

[Theo]

No problem.

https://hg.adblockplus.org/easylist/rev/78edc0a03259
^ Hmm... it seems that in this revision, the

Code: Select all

neopets.com###ban

filter was added again. I think there have been some more layout changes on the site as well, because the top part of the page looks all right now.

However, there's a bit of a long standing problem with this filter which I thought I should mention. I presume it was added to get rid of the grey space at the top of the page[1] which appears in the default and basic site themes. However, in some other themes available to users[2][3][4], that same space is used to display images that are part of the theme.

I have no idea what the best way to deal with this is...

[1] http://i151.photobucket.com/albums/s128 ... -basic.png
[2] http://i151.photobucket.com/albums/s128 ... r-aota.png
[3] http://i151.photobucket.com/albums/s128 ... er-apc.png
[4] http://i151.photobucket.com/albums/s128 ... er-ros.png

[Erunno]

Hi theo,

can you give me some pointers on how to change the theme to the ones shown in your screenshots? I haven't had luck so far with the "Theme" settings in the site preferences, which changes only the color of the star background.

[Theo]

That is the right section to pick themes from, but the site themes I took screenshots of have to be unlocked by participating in site events or other activities. As far as I know the only one currently attainable is the third one, which is unlocked after completing the Altador Plot[1] - but, well, that's quite a bit of work!

As far as I can tell, the page layouts for different site themes are pretty much the same, they just use different CSS files to pull in the different images. If you need any more information on the coding, I can try and provide it for you.

[1] If you want to take a shot, there's a walkthrough here

[Erunno]

https://hg.adblockplus.org/easylist/rev/c98370257faa

I have removed the filter for the time being. Theo, can you verify that EasyList does not interfere with the unlockable themes anymore? You'll probably have to force an subscription update form the Adblock Plus menu beforehand.

[Theo]

The unlockable themes now function perfectly.

[Erunno]

I'll mark this topic as fixed then.

[Theo]

The filter

Code: Select all

neopets.com###ban

was added in https://hg.adblockplus.org/easylist/rev/6e7ef385ddf4 - presumably this was to block the empty grey space that shows up in the header in the default theme. However, this filter causes two problems:

1) The grey space in the default theme actually makes up (an unimportant but pretty) part of several unlockable user themes on the site. See this topic for previous discussion on the issue.
2) When used in AdBlock for Chrome (but not Adblock Plus), the filter collapses the entire header section of the site, rendering the navigation bar and other critical page elements inaccessible.

Could this change please be reverted? Even without the filter, no ads appear in the header.

Thanks in advance.

[Khrin]

I apologize for the problem. Removed: https://hg.adblockplus.org/easylist/rev/71665f2a09be

[Theo]

The header is now displaying properly. Thanks for the quick fix!