improper use of Cyrillic small a in 'target="_blank"' in hiding rules

General information, announcements and questions about the EasyList subscriptions.

Moderator: EasyList authors

Locked
lewisje
Site Member
Site Member
Posts: 15
Joined: Mon Mar 28, 2016 4:10 pm
Reputation: 0

improper use of Cyrillic small a in 'target="_blank"' in hiding rules

Post by lewisje » Thu May 11, 2017 8:54 am

The creator of uBlock Origin has found that three places in EasyList use the Cyrillic lowercase a where the ASCII lowercase a should be used, specifically in the target="_blank" selector inside three hiding rules: https://github.com/gorhill/uBlock/issues/2598

His issue was that they cause the JS engine to use an inefficient internal storage method for strings, but my issue is that it isn't even the proper form for that special keyword in HTML.

lewisje
Site Member
Site Member
Posts: 15
Joined: Mon Mar 28, 2016 4:10 pm
Reputation: 0

Post by lewisje » Thu May 11, 2017 3:03 pm

I can't seem to edit my posts, but I have just learned that those three filters were correctly crafted, because the sites in question really do use those characters that way: https://github.com/gorhill/uBlock/issue ... -300776123

Locked